You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is less of an issue with the KeyDrop (#27)
but if KeyDrop isn't use it would be nice to create this code in a different language and use the same keys.
Right now it is using php serialize which can probably be replaced with json_encode / json_decode
I used serialize advisedly, because JSON is utterly useless for binary strings unless you pre-encode them and secret tokens are fairly likely to contain such strings. Eventually it should be migrated to msgpack or some other less language-specific binary encoding. That's one reason for the encoding type prefix (that "p" there).
Though actually, I wouldn't mind trying to pre-flight a conversion to JSON ("j" prefix) and fall back to serialize only if the value contains non-UTF8 strings.
This is less of an issue with the KeyDrop (#27)
but if KeyDrop isn't use it would be nice to create this code in a different language and use the same keys.
Right now it is using php serialize which can probably be replaced with json_encode / json_decode
lockbox/src/Secret.php
Line 128 in db3dbc1
lockbox/src/Secret.php
Line 157 in db3dbc1
The text was updated successfully, but these errors were encountered: