Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay change that broke proxy #584

Closed
kevkevinpal opened this issue Feb 3, 2023 · 7 comments · May be fixed by #589
Closed

Relay change that broke proxy #584

kevkevinpal opened this issue Feb 3, 2023 · 7 comments · May be fixed by #589
Assignees
Labels
Automated Testing When new test converage needs to be added with no actual modifications to the functionality bug Something isn't working

Comments

@kevkevinpal
Copy link
Contributor

This change broke proxy https://github.com/stakwork/sphinx-relay/pull/523/files

not sure why the test didn't break because users were not able to receive mqtt messages.

We should try applying these changes and getting the tests to fail

@kevkevinpal
Copy link
Contributor Author

https://github.com/stakwork/sphinx-relay/blob/master/src/tests/controllers/tribe3Messages.test.ts

some of these tests dont even use proxy which maybe the reason this change passed integration testing

@kevkevinpal
Copy link
Contributor Author

Adding some new test changes here, will check with the change that we reverted to make sure the test fails

kevkevinpal#21

@kevkevinpal kevkevinpal self-assigned this Feb 3, 2023
@kevkevinpal kevkevinpal added Automated Testing When new test converage needs to be added with no actual modifications to the functionality bug Something isn't working labels Feb 3, 2023
@kevkevinpal
Copy link
Contributor Author

@Evanfeenstra looks like the cryptian issues were not just on the proxy node looks like the automated tests are failing to build the modules aswell

https://github.com/stakwork/sphinx-relay/actions/runs/4085405458/jobs/7043333139

@Evanfeenstra
Copy link
Contributor

@kevkevinpal you can set jsceyptor-2 back to v0.0.1 to use mcrypt again instead of cryptian

@kevkevinpal
Copy link
Contributor Author

Ok thanks @Evanfeenstra looks like its building and passing now, going to add the change that broke proxy to the PR to get the test to fail

@kevkevinpal
Copy link
Contributor Author

This add more proxy users stakwork/sphinx-stack#56

but it seems this wont fix the issue we had since it was trying to connect the already existing proxy users to mqtt but the way sphinx-stack is setup is that it generate new proxy users. I can explore to see if we can just have an existing state in proxy that we can startup from

@kevkevinpal
Copy link
Contributor Author

closing this cause we solved the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automated Testing When new test converage needs to be added with no actual modifications to the functionality bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants