Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display fee when paying invoice #269

Open
tomsmith8 opened this issue Dec 7, 2023 · 1 comment
Open

Display fee when paying invoice #269

tomsmith8 opened this issue Dec 7, 2023 · 1 comment

Comments

@tomsmith8
Copy link

tomsmith8 commented Dec 7, 2023

Task

If queryRoute is greater than amount + balance the backend will return an error before paying - here

  • Display est. fee
  • if amount + fee is larger than balance, the backend will return error message "Insufficient balance" upon verifying the invoice.

This will happen when you verify the invoice, we'll get a response from the backend with error message that payment exceeds balance.

Design

Image

@tomastiminskas
Copy link
Contributor

@tomsmith8 I was checking into the relay changes and it's not actually returning the error on queryRoute endpoint, but on payInvoice/ sendKeysend endpoints. So we don't have a way to show fee to user before it confirms the payment.

@Evanfeenstra we will need to apply this to queryRoute endpoint or add a new endpoint to get estimated fee for an invoice or a key send. That way we can show fees to user before he confirms the pmt. Let me know if it makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants