Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCE] improve HA by not syncing after restart if a replica was running that becomes leader #810

Open
mmerickel opened this issue Dec 10, 2024 · 0 comments
Labels
kind/enhancement New feature or request

Comments

@mmerickel
Copy link

The docs state that if reloadOnCreate is set then when a new leader is elected all pods will be restarted. This could be fixed if you re-define HA to have 2 replicas both watching and maintaining internal state about secrets but with only the leader applying changes to trigger restarts. This way, when replica A (leader) dies, replica B (not leader) is still watching, understanding that the secrets haven't changed, such that when replica B becomes leaders it can rely on its state to know it doesn't need to restart the pod because that pod's secrets didn't change.

I know this is a lot more effort than simple leader election to disable one replica B while replica A is the leader, but it is quite disruptive to have to restart all pods just because the reloader leader changed when we did have 2 replicas running.

Anyway, hopefully this is a useful thought because right now you can't really have proper tracking of secrets changes across leaders even if we have multiple replicas running. :-(

@mmerickel mmerickel added the kind/enhancement New feature or request label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant