Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCE] Add conflict retries to handle "the object has been modified; please apply your changes to the latest version and try again" #766

Open
sthomson-wyn opened this issue Oct 11, 2024 · 3 comments · May be fixed by #770
Open

[ENHANCE] Add conflict retries to handle "the object has been modified; please apply your changes to the latest version and try again" #766

sthomson-wyn opened this issue Oct 11, 2024 · 3 comments · May be fixed by #770
Labels
kind/enhancement New feature or request

Comments

@sthomson-wyn
Copy link

Is your feature request related to a problem? Please describe.
Seemingly frequently, I run into "the object has been modified; please apply your changes to the latest version and try again". This is normal and expected in k8s where multiple controllers might make modifications. However, it looks like reloader just goes back to the start and retries everything again.

Describe the solution you'd like
Use the build in k8s client retry utility

Describe alternatives you've considered
I can't really find a way to stop reloader from failing upon running into this issue
@sthomson-wyn sthomson-wyn added the kind/enhancement New feature or request label Oct 11, 2024
@sthomson-wyn
Copy link
Author

I'll make a PR for this

@sthomson-wyn
Copy link
Author

I'll also note that I run into this often when doing a rolling upgrade on a large amount of deployments, reloader just doesn't get through them fast enough. Too much time passes between the initial retrieval of the deployments, and the attempted update

@MuneebAijaz
Copy link
Contributor

preferred solution is to send patch requests instead of update requests. We wont need retry logic then, in my experience Ive never seen patch requests clash with latest CR on the cluster. But this retry-all logic might needs a look

@sthomson-wyn sthomson-wyn linked a pull request Oct 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add conflict retries sthomson-wyn/Reloader
2 participants
@MuneebAijaz @sthomson-wyn