Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have an exclude option introduced that can be configured at deployment/sts level #740

Open
rajivml opened this issue Sep 4, 2024 · 2 comments · May be fixed by #764
Open

Can we have an exclude option introduced that can be configured at deployment/sts level #740

rajivml opened this issue Sep 4, 2024 · 2 comments · May be fixed by #764
Labels
kind/enhancement New feature or request kind/help wanted Extra attention is needed

Comments

@rajivml
Copy link

rajivml commented Sep 4, 2024

Could we introduce an "exclude" option that can be configured at the deployment and statefulset level? This option would allow us to specify a list of secret and configmap names for which we do not want to trigger a rolling restart.

Use case: We are a platform team responsible for ensuring best practices across 30+ teams within our organization.

When updating certain secrets, such as istio-secret-configmap, we want to enforce a rolling restart of all deployments, so service teams don't need to manually include this secret under the annotation configmap.reloader.stakater.com/reload.

However, for other secrets, like kerberos-token-secret, we want to provide service teams with the flexibility to determine whether a rolling restart is necessary, depending on whether the SDK they use supports hot reloading. In such cases, teams would indicate this by adding the relevant secret name under configmap.reloader.stakater.com/reload.

  • We can't use secret.reloader.stakater.com/auto: "true" as this will act on all referenced cm's and secrets
  • Currently, we use the annotation configmap.reloader.stakater.com/reload, but the issue with this approach is that, for secrets like istio-secret-configmap, where we want to enforce a mandatory rolling restart, we have to update all Helm charts that correspond to all service teams
  • A label-based approach does not work because, for some secrets/configmaps, we want to give users the flexibility to decide whether a deployment or statefulset requires a rolling restart.

This problem could be resolved by introducing an annotation like configmap.exclude.reloader.stakater.com/reload, where service teams can simply list the secrets/cm's for which they do not want to trigger a rolling restart

@rajivml rajivml added the kind/enhancement New feature or request label Sep 4, 2024
@bnallapeta
Copy link

@rajivml Yes, this is a feature we do not have at the moment. Please feel free to open a PR.

Relates to #284 #317

@MuneebAijaz MuneebAijaz added the kind/help wanted Extra attention is needed label Sep 11, 2024
@LochanRn
Copy link

/assign LochanRn

@LochanRn LochanRn linked a pull request Oct 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request kind/help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants