Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCE] Cron like maintenance window for pods #755

Open
Demch1k opened this issue Sep 30, 2024 · 4 comments
Open

[ENHANCE] Cron like maintenance window for pods #755

Demch1k opened this issue Sep 30, 2024 · 4 comments
Labels
kind/enhancement New feature or request kind/help wanted Extra attention is needed

Comments

@Demch1k
Copy link

Demch1k commented Sep 30, 2024

Hello everyone!
How do you think is it possbile to create label for allowed maintenance window for reloading pods?
We have sort of applications that use certificates and after experation it should be reloaded in time for example at 2 A.M. due high load.
But reloader does it straightaway configmaps/secrets changes.

Another question is how reloader detects changes that has done in time when reloader was turned off?
Will it be checked by reloader or just gone?

@Demch1k Demch1k added the kind/enhancement New feature or request label Sep 30, 2024
@MuneebAijaz
Copy link
Contributor

hi @Demch1k, this feature can be added to Reloader as it aligns with the project, but we don't have active developers on this project so the community will need to work on it. PRs are welcome.

@MuneebAijaz MuneebAijaz added the kind/help wanted Extra attention is needed label Oct 2, 2024
@wololowarrior
Copy link

wololowarrior commented Oct 4, 2024

hi @MuneebAijaz ,
I would like to contribute as my companies platform relies on Reloader.
Thus, I can help but would this be considered a good first issue for this repo? If yes, would you be open to some light shepherding?

@MuneebAijaz
Copy link
Contributor

hi @wololowarrior , I'd consider this to be a bit complex issue. I myself havent looked at the details yet of how it would be possible. Issues for newcomers are labelled as good-first-issue across the repos in opensource org. https://github.com/stakater/Reloader/issues?q=is%3Aopen+is%3Aissue+label%3Agood-first-issue

If you need this change or would still like to work on it, i can guide you

@wololowarrior
Copy link

@MuneebAijaz I would like to give this a try:

  1. Can the maintenance window be applied at a deployment level?
  2. Do we want it be an annotation?
  • What would its value be? a time range maybe?
  1. How do we handle the part where a change happened when we were not in the maintenance window?
  • This mean we cannot restart the pods and any update request that comes in outside of the maintenance window might be kept somewhere to applied during the window?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request kind/help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants