[BUG] With kubernetes/eks 1.30 or higher and sleep lifecycle the controller not restart deployment

[mlophez]

Describe the bug
When using Kubernetes 1.30 or higher, the Deployment object adds new lifecycle policies, such as sleeplifecycle.
https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/

When you add this, the controller throws the following error and not restart deployment:

time="2024-09-26T06:24:29Z" level=error msg="Update for of type 'Deployment' in namespace 'core' failed with error Deployment.apps is invalid: spec.template.spec.containers[0].lifecycle.preStop: Required value: must specify a handler type"

This happens because, in the current project libraries, the Deployment object does not have those properties.
When we updated the project's libraries to version 1.31, the problem was resolved.

´´´
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go get k8s.io/[email protected]
´´´

To Reproduce
Use kubernetes 1.30 and use deployment with lifecycle sleep or kubernetes 1.29 with de alpha feature enable

Expected behavior
The controller must be function as normally

Environment

• Operator Version: master
• Kubernetes/OpenShift Version: 1.31

Additional context

[MuneebAijaz]

@mlophez PRs are welcome for this fix. However, we would prefer it if the change can be tested on older versions to make sure it doesn't break community on older kubernetes versions. (< 1.30)

[mlophez]

Hi @MuneebAijaz, i open PR for this, only update k8s libraries.

Unfortunately, I cannot test on earlier versions because our EKS clusters have already been updated. However, the Kubernetes libraries should be backward compatible with previous versions.

[Agger1995]

Hi @MuneebAijaz.
What is the status on this issue? We are currently unable to utilize the new sleep preStop hooks due to this issue. Is it possible to get a release with this bug fix?

[MuneebAijaz]

hi @Agger1995 Pls verify if its accessible now via 1.2.1 version

[Agger1995]

Hi! Thank you for the swift release. We are upgrading Reloader as we speak.