-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service worker errors in console? #1822
Comments
There may be some waitUntil(s) that are useless but got added for precaution, the errors should spawn only on service worker's console though. Edit: more likely onPushSubscriptionChange since it gets triggered at every load without releasing any kind of promise, I'm not sure though as I'm not getting any errors if (event.data.action === SYNC_SUBSCRIPTION) {
return event.waitUntil(onPushSubscriptionChange(sw)(event, true))
} edit2: I'm starting to think the culprit is google's workbox because I'm not getting errors from the eventListener |
Oh, thanks! I had a suspicion about it (waitUntil is called a bit too much after) but the lack of errors threw me far from it, posting a fix real quick! |
Apparently the error was there because |
I'm not sure if this is normal or related to #1821 but I'm seeing these in prod.
The text was updated successfully, but these errors were encountered: