Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API improvement suggestion: decodeObjects → decodeObjectList #6

Open
daniel-v opened this issue Jul 2, 2018 · 1 comment
Open

Comments

@daniel-v
Copy link

daniel-v commented Jul 2, 2018

Cool project! I can see myself using it. One of the things I ran into when testing things was that pesky s.

We have things that look like this:

    members = object.decodeObjects("members", () => Person());
    manager = object.decodeObject("manager", () => Person());

As it turns out, I am a functional analphabet and that extra s to indicate that we are talking about an interable skipped me. I think I would have spotted my error if the indication was much more explicit. Something like object.decodeObjectList

What do you think?

@itsjoeconway
Copy link
Contributor

Sure. I think having both and having one proxy into another is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants