Incorrect get() documentation/buggy function

[Powersource]

This section says "If opts is passed, the message id is taken from either opts.id or opts.key" but when I test

        server.get({ id: rootKey, meta: true }, (err, rootMsg) => {

that works, but

        server.get({ key: rootKey, meta: true }, (err, rootMsg) => {

doesn't. I get this

/home/me/prj/ssb/ssb-wiki/node_modules/ssb-ref/index.js:77
  return s[0] === '%' && isLink(s)
          ^

TypeError: Cannot read property '0' of undefined
    at Object.exports.isMsgLink (/home/me/prj/ssb/ssb-wiki/node_modules/ssb-ref/index.js:77:11)
    at EventEmitter.db.get (/home/me/prj/ssb/ssb-wiki/node_modules/ssb-db/create.js:100:20)
    at apply (/home/me/prj/ssb/ssb-wiki/node_modules/muxrpc-validation/index.js:197:15)
    at EventEmitter.<anonymous> (/home/me/prj/ssb/ssb-wiki/node_modules/muxrpc-validation/index.js:86:14)
    at EventEmitter.hooked [as get] (/home/me/prj/ssb/ssb-wiki/node_modules/hoox/index.js:10:15)
    at /home/me/prj/ssb/ssb-wiki/index.js:77:16
    at /home/me/prj/ssb/ssb-wiki/node_modules/pull-stream/sinks/reduce.js:10:5
    at /home/me/prj/ssb/ssb-wiki/node_modules/pull-stream/sinks/drain.js:20:24
    at /home/me/prj/ssb/ssb-wiki/node_modules/pull-stream/throughs/through.js:19:9
    at /home/me/prj/ssb/ssb-wiki/node_modules/pull-stream/throughs/filter.js:17:11

If this is actually supposed to work, then when I skimmed the code it looked like this function came directly from flumedb so the bug might be there instead but I'm not sure.

[mixmix]

confirmed, I also recently got this behaviour :(

What do we want the actual behaviour to be?

[christianbundy]

What do we want the actual behaviour to be?

I like 'id', but whatever the docs say is fine with me.

[mixmix]

I think being able to pay id or key in (but not both!) seems good

…

On Tue, 23 Jun 2020, 05:12 Christian Bundy, ***@***.***> wrote: What do we want the actual behaviour to be? I like 'id', but whatever the docs say is fine with me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#287 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUK3HUUTMQTZ36IJDFASBDRX6GGPANCNFSM4MRNHCNQ> .

[christianbundy]

Sounds like we should just fix the docs then. 🚀

[mixmix]

No what I meant was it should accept either ID OR Key but throw an error if both are supplied!

…

On Tue, 30 Jun 2020, 03:39 Christian Bundy, ***@***.***> wrote: Sounds like we should just fix the docs then. 🚀 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#287 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUK3HQHNESMYTRJ2XW6NK3RZCYUHANCNFSM4MRNHCNQ> .

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

[christianbundy]

(iIf you assign yourself ("I'm someone who wants this issue to stay open") then the bot will never touch it.)

[mixmix]

Keep this open please

…

On Fri, 11 Dec 2020, 08:14 Christian Bundy, ***@***.***> wrote: (iIf you assign yourself ("I'm someone who wants this issue to stay open") then the bot will never touch it.) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#287 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUK3HSCPPUH6D7IZA7X2R3SUEMZDANCNFSM4MRNHCNQ> .

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?