Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider forking weaveworks/ignite #1351

Closed
gaby opened this issue Apr 29, 2023 · 6 comments
Closed

Consider forking weaveworks/ignite #1351

gaby opened this issue Apr 29, 2023 · 6 comments

Comments

@gaby
Copy link
Contributor

gaby commented Apr 29, 2023

Containerlab is the biggest project using weaveworks/ignite right now. The project seems to have been abandoned since weaveworks is now focused on gitops. It may be worth for containerlab to fork and at least update deps for ignite.

Rel weaveworks/ignite#971

@hellt
Copy link
Member

hellt commented Apr 29, 2023

Hi @gaby
We are using the fork done by @networkop. Looks like for now it does all that is needed.

@gaby
Copy link
Contributor Author

gaby commented Apr 29, 2023

@hellt Your go.mod still points to weaveworks though:

https://github.com/srl-labs/containerlab/blob/main/go.mod#L39

@hellt
Copy link
Member

hellt commented Apr 29, 2023

@gaby

replace (

@gaby
Copy link
Contributor Author

gaby commented Apr 29, 2023

@gaby

replace (

😁 Didn't see that. Seems like even that one still has the CNI issue. Ignite was never updated to cni v1.0.0 while containerlab does use it. Not sure if that's an issue 🤔

Just wanted to make sure that containerlab was aware of ignite being abandoned.

@hellt
Copy link
Member

hellt commented Apr 29, 2023

We are not using it much to be honest. Only cumulus nodes leverage ignite, and a few corner cases for Linux containers.

We wont maintain it either, all the hope is with @networkop :)

@hellt hellt closed this as completed Apr 29, 2023
@networkop
Copy link
Contributor

Yep, feel free to tag me in any ignite-related issues. I'll try to keep it alive for as long as it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants