Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis 7 Support #185

Open
ronaldpetty opened this issue Mar 3, 2022 · 7 comments
Open

Redis 7 Support #185

ronaldpetty opened this issue Mar 3, 2022 · 7 comments

Comments

@ronaldpetty
Copy link

Hello, I just gave the rdb tool a try against an RDB file from Redis 7 rc 2.

~/replication$ rdb --command diff ./master/dump.rdb
Traceback (most recent call last):
  File "/usr/local/bin/rdb", line 11, in <module>
    load_entry_point('rdbtools==0.1.15', 'console_scripts', 'rdb')()
  File "/home/ubuntu/.local/lib/python3.8/site-packages/rdbtools/cli/rdb.py", line 106, in main
    parser.parse(options.dump_file[0])
  File "/home/ubuntu/.local/lib/python3.8/site-packages/rdbtools/parser.py", line 394, in parse
    self.parse_fd(open(filename, "rb"))
  File "/home/ubuntu/.local/lib/python3.8/site-packages/rdbtools/parser.py", line 399, in parse_fd
    self.verify_version(f.read(4))
  File "/home/ubuntu/.local/lib/python3.8/site-packages/rdbtools/parser.py", line 963, in verify_version
    raise Exception('verify_version', 'Invalid RDB version number %d' % version)
Exception: ('verify_version', 'Invalid RDB version number 10')

Just for giggles, I changed the 10 to a 09 and it seems to work (at least diffing).

@smilyFw
Copy link

smilyFw commented Mar 3, 2022 via email

@ronaldpetty
Copy link
Author

ronaldpetty commented Mar 3, 2022

别客气

#186

@madolson
Copy link

madolson commented Aug 5, 2022

It should mostly work, there are a couple of new RDB op codes like functions that need to be supported.

@smilyFw
Copy link

smilyFw commented Aug 5, 2022 via email

@ChenWei-XiaoYi
Copy link

ChenWei-XiaoYi commented Aug 5, 2022 via email

@rhuddleston
Copy link

rhuddleston commented Nov 11, 2022

on upgrade Hash types are auto-converted RDB_TYPE_HASH -> RDB_TYPE_HASH_LISTPACK so at a minimum rdb-tools will need to be upgraded to understand how to decode HASH_LISTPACK objects.

redis/redis#8887

@smilyFw
Copy link

smilyFw commented Nov 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants