Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New language for OWNERS? #180

Closed
campoy opened this issue Nov 15, 2018 · 3 comments
Closed

New language for OWNERS? #180

campoy opened this issue Nov 15, 2018 · 3 comments
Labels

Comments

@campoy
Copy link
Contributor

campoy commented Nov 15, 2018

Should OWNERS file have their own language?

For instance, this file https://github.com/kubernetes/apimachinery/blob/master/Godeps/OWNERS returns an empty language selection.

According to this post it's a YAML file but we fail to identify it.

@bzz bzz added the question label Nov 23, 2018
@bzz
Copy link
Contributor

bzz commented Nov 23, 2018

This is really nice suggestion, but enry relies on exact heuristics from github/linguist for language detection - by design, it supports only the things that linguist does support though auto-generating Go code that use exactly the same heuristics/number of languages/etc.

So I would say this request need to be filed upstream.

@campoy
Copy link
Contributor Author

campoy commented Nov 26, 2018

Interesting, maybe it's a good way to contribute to the linguist project then.
I'll let the @src-d/language-analysis team decide on this.

@bzz
Copy link
Contributor

bzz commented Nov 27, 2018

👍 and I forgot to mention - it's not the latest linguist rules that we are using and there is also a plan to sync up with latest upstream #155

Closing in favor of umbrella #181

@bzz bzz closed this as completed Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants