Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region and endpoint additional config to readme #528

Open
pointtoken opened this issue Aug 7, 2020 · 1 comment
Open

Add region and endpoint additional config to readme #528

pointtoken opened this issue Aug 7, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@pointtoken
Copy link

Great library! It might be useful in the docs to show how to configure the library, as follows:

   const seasons = new Isotope<Season>({
    domain: "seasons",                     
    key: "id"                            
  }, { region 		: 'US-East',
  endpoint 	: 'https://sdb.amazonaws.com'} );

Without this additional config, I couldn't get things working...

@squidfunk
Copy link
Owner

squidfunk commented Aug 7, 2020

Thanks for noting! Definitely needs to be in the docs 😄 The reason why it's not is that I still need to revisit the configuration design. I probably change it to a further key of the first parameter and maybe refactor the other options.

@squidfunk squidfunk added the enhancement New feature or request label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants