Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we version this image? #68

Open
gerhard opened this issue Nov 18, 2024 · 1 comment
Open

Should we version this image? #68

gerhard opened this issue Nov 18, 2024 · 1 comment

Comments

@gerhard
Copy link

gerhard commented Nov 18, 2024

Hi @squat!

Considering the attention that the plugin is getting in:

Would you be open to accepting a PR that versions the resulting image?

While we could pin to a specific git version & sha256 from https://github.com/squat/generic-device-plugin/pkgs/container/generic-device-plugin/versions?filters%5Bversion_type%5D=tagged, I would feel a lot more comfortable picking up an actual tag - CalVer works!


cc @smira @konrad-ohms

@squat
Copy link
Owner

squat commented Nov 18, 2024

Hi @gerhard, thanks for bringing those discussions to my attention! I'm glad to see some activity. I've always used SHAs for pinning this project, however I'm happy to release a semver v0.1.0 if that works for ppl and would be grateful for a PR to that effect :)

I've been lazy to cut a 1.0.0 because I have a large-ish re-write pending that I want to get in before that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants