Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined method in index.js:417 #4

Open
krebsBenjamin opened this issue Jan 31, 2020 · 1 comment
Open

undefined method in index.js:417 #4

krebsBenjamin opened this issue Jan 31, 2020 · 1 comment

Comments

@krebsBenjamin
Copy link

When stopping a session the following error message is produced:

ReferenceError: resolve is not defined
at _stopSession.then (node_modules/karma-selenium-grid-launcher/index.js:417:11)
at process._tickCallback (internal/process/next_tick.js:68:7)

There are already a pull request available fixing this issue. Can you merge that and produce a new release?

Much appreciated.
/Benjamin
@gogza
Copy link

gogza commented Dec 7, 2020

This is the same issue as Issue 5 - if you are looking for a working copy - go see ErDmKo's fork.

instructure-gerrit pushed a commit to instructure/canvas-lms that referenced this issue Jun 12, 2024
@aaronshaf
restore Karma/QUnit tests and re-enable partitioning
4d0d89b 
also:
 - include tests with .jsx extension
 - automate partitioning of all QUnit tests
 - move old Ember-related tests back to their prior suffix
 - skip tests either consistently failing locally
   or in Jenkins
   - sometimes due to lack of maintenance (some weren't
     running before), or due to different order
     of running tests
 - fix some tests
 - upgrades karma-selenium-grid-launcher to fork which
   resolves longstanding bug
     cf. squarebracket/karma-selenium-grid-launcher#4

skips three Gradebook-related test files that consistently hang
  in Jenkins, cf. EVAL-4267

Change-Id: Ib79f75963f6c4f5544e5dc1b5c31bc58d6c1110c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/349561
Reviewed-by: Isaac Moore <[email protected]>
Tested-by: Service Cloud Jenkins <[email protected]>
QA-Review: Aaron Shafovaloff <[email protected]>
Product-Review: Aaron Shafovaloff <[email protected]>
Build-Review: James Butters <[email protected]>
s1050613 pushed a commit to s1050613/canvas-lms that referenced this issue Jun 14, 2024
@aaronshaf @s1050613
restore Karma/QUnit tests and re-enable partitioning
5125efb 
also:
 - include tests with .jsx extension
 - automate partitioning of all QUnit tests
 - move old Ember-related tests back to their prior suffix
 - skip tests either consistently failing locally
   or in Jenkins
   - sometimes due to lack of maintenance (some weren't
     running before), or due to different order
     of running tests
 - fix some tests
 - upgrades karma-selenium-grid-launcher to fork which
   resolves longstanding bug
     cf. squarebracket/karma-selenium-grid-launcher#4

skips three Gradebook-related test files that consistently hang
  in Jenkins, cf. EVAL-4267

Change-Id: Ib79f75963f6c4f5544e5dc1b5c31bc58d6c1110c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/349561
Reviewed-by: Isaac Moore <[email protected]>
Tested-by: Service Cloud Jenkins <[email protected]>
QA-Review: Aaron Shafovaloff <[email protected]>
Product-Review: Aaron Shafovaloff <[email protected]>
Build-Review: James Butters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gogza @krebsBenjamin