Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify DefaultMethodInvokingMethodInterceptor #2971

Closed
odrotbohm opened this issue Nov 8, 2023 · 0 comments
Closed

Simplify DefaultMethodInvokingMethodInterceptor #2971

odrotbohm opened this issue Nov 8, 2023 · 0 comments
Assignees
@odrotbohm
Labels
in: core Issues in core support theme: aot An issue related to Ahead-Of-Time processing
Milestone
3.0.12 (2022.0.12)

Comments

@odrotbohm
Copy link
Member

The implementation of DefaultMethodInvokingMethodInterceptor currently uses a lot of indirection and reflection, stemming from the times that creating a Lookup instance needed to be performed in different ways depending on the Java version (8 VS. 9). Now that we have Java 17 as baseline, we can simplify this arrangement and avoid reflection completely.
@odrotbohm odrotbohm added the in: core Issues in core support label Nov 8, 2023
@odrotbohm odrotbohm self-assigned this Nov 8, 2023
@odrotbohm odrotbohm added the theme: aot An issue related to Ahead-Of-Time processing label Nov 8, 2023
odrotbohm added a commit that referenced this issue Nov 8, 2023
@odrotbohm
Simplify DefaultMethodInvokingMethodInterceptor.
6bd28a1 
As our baseline is now Java 17, we can remove all indirections to produce a Lookup previously needed to support Java 8 and 9.

Fixes #2971.
odrotbohm added a commit that referenced this issue Nov 8, 2023
@odrotbohm
Simplify DefaultMethodInvokingMethodInterceptor.
17bbdf3 
As our baseline is now Java 17, we can remove all indirections to produce a Lookup previously needed to support Java 8 and 9.

Fixes #2971.
@odrotbohm odrotbohm added this to the 3.0.12 (2022.0.12) milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Issues in core support theme: aot An issue related to Ahead-Of-Time processing
Projects
None yet
Milestone
3.0.12 (2022.0.12)
Development

No branches or pull requests
1 participant
@odrotbohm