Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation about include/exclude filters describes the inverse behavior #2969

Closed
krishu1501 opened this issue Nov 5, 2023 · 1 comment
Labels
type: documentation A documentation update

Comments

@krishu1501
Copy link

In the official documentation, Section 4.5.3. Using Filters, the last line has an error :
https://docs.spring.io/spring-data/jpa/docs/current/reference/html/#repositories.using-filters

The preceding example excludes all interfaces ending in SomeRepository from being instantiated and includes those ending with SomeOtherRepository.

Instead it will be vice versa as per the given example in the section. It will exclude all those ending with SomeOtherRepository and include those ending with SomeRepository

@EnableJpaRepositories(basePackages = "com.acme.repositories",
includeFilters = { @Filter(type = FilterType.REGEX, pattern = ".*SomeRepository") }, excludeFilters = { @Filter(type = FilterType.REGEX, pattern = ".*SomeOtherRepository") })

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 5, 2023
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 6, 2023
@mp911de mp911de transferred this issue from spring-projects/spring-data-jpa Nov 6, 2023
@mp911de
Copy link
Member

mp911de commented Nov 6, 2023

I moved the ticket into Spring Data Commons as this repository hosts the documentation source.

@mp911de mp911de changed the title Error in Documentation(repositories using-filters) Documentation about include/exclude filters describes the inverse behavior Nov 6, 2023
mp911de added a commit that referenced this issue Nov 6, 2023
@mp911de mp911de closed this as completed in 96f8ee2 Nov 6, 2023
mp911de added a commit that referenced this issue Nov 6, 2023
@mp911de mp911de added this to the 3.0.12 (2022.0.12) milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

3 participants