Fallback to StringUtils.uncapitalize(…) when looking up property paths
#2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
changed the title
StringUtils.decapitalize(…) when looking up property pathsStringUtils.uncapitalize(…) when looking up property paths
src/test/java/org/springframework/data/mapping/PropertyPathUnitTests.java
Show resolved
Hide resolved
|
I think we should also update the |
christophstrobl
force-pushed
the
issue/1851
branch
from
4ce5c29 to
de92244
Compare
Naming restrictions for property paths used in query method names requite capitalization of the first letter regardless whether the property name uses a second-letter uppercase form (zIndex -> ZIndex, qCode -> QCode). In such cases, Introspector.decapitalize(…) shortcuts to non-decapitalization as it checks the second letter casing. This leads to the case that the property name cannot be resolved, assuming proper property naming (getzIndex(), zIndex()). Falling back to StringUtils.uncapitalize() allows catching such properties.
Fix test naming. Improve equals check by caching resolved generics.
christophstrobl
force-pushed
the
issue/1851
branch
from
de92244 to
0d5a9bc
Compare
christophstrobl
pushed a commit
that referenced
this pull request
Nov 21, 2023
Naming restrictions for property paths used in query method names requite capitalization of the first letter regardless whether the property name uses a second-letter uppercase form (zIndex -> ZIndex, qCode -> QCode). In such cases, Introspector.decapitalize(…) shortcuts to non-decapitalization as it checks the second letter casing. This leads to the case that the property name cannot be resolved, assuming proper property naming (getzIndex(), zIndex()). Falling back to StringUtils.uncapitalize() allows catching such properties. Closes: #1851 Original Pull Request: #2940
christophstrobl
pushed a commit
that referenced
this pull request
Nov 21, 2023
Fix naming. Original Pull Request: #2940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming restrictions for property paths used in query method names require capitalization of the first letter regardless whether the property name uses a second-letter uppercase form (zIndex -> ZIndex, qCode -> QCode). In such cases,
Introspector.decapitalize(…)shortcuts to non-decapitalization as it checks the second letter casing.This leads to the case that the property name cannot be resolved, assuming proper property naming (
getzIndex(),zIndex()).Falling back to
StringUtils.uncapitalize()allows catching such properties.Closes #1851