Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check using spring-boot actuator health endpoint #266

Open
MorrisZ opened this issue Sep 9, 2020 · 6 comments · May be fixed by #283
Open

Health check using spring-boot actuator health endpoint #266

MorrisZ opened this issue Sep 9, 2020 · 6 comments · May be fixed by #283

Comments

@MorrisZ
Copy link

MorrisZ commented Sep 9, 2020

Problem
I have a customized HealthIndicator that simply marks the service as 'DOWN'.
But when I checked the znode data, it showed that 'instance_status' was 'UP'.

When using spring-cloud-gateway along with zookeeper registry, I expect that it would NOT forward requests to a service being 'DOWN'. But for now it seems impossible.

@JWThewes
Copy link

I solved that on my own by using a scheduler and querying the health endpoint.
Would happily provide a PR for this if this is a way to go.

@JWThewes
Copy link

@spencergibb Any interest that I provide a PR? Or is this not the way to go?

@JWThewes
Copy link

@spencergibb @OlgaMaciaszek Any interest in a PR for this one.

@spencergibb
Copy link
Member

Yes, PRs welcome, that's why it's labeled "help wanted"

JWThewes added a commit to JWThewes/spring-cloud-zookeeper that referenced this issue Feb 17, 2021
…HealthEndpoint to respect custom HealthIndicator instances. Therfore a ZookeeperInstanceHealthPublisher is introduced. Only activated when HealthEndpoint and TaskScheduler are available. fixedDelay can be configured. Fixes spring-cloudgh-266
@JWThewes
Copy link

Took some time because pandemic times require me too be there for my children. But now I've finally provided a solution for this.

@spencergibb
Copy link
Member

Totally understandable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants