New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The regex for double values does not consider possible values ("E-", e.g.: 1.0074598709275406E-4) #2043

Open

IvanBurliaiev opened this issue Nov 21, 2023 · 1 comment

Labels

bug

IvanBurliaiev commented Nov 21, 2023 •

edited

Loading

https://github.com/spring-cloud/spring-cloud-contract/blob/cd0fffa972cf3065c29ec1b29b13585c30a7345a/specs/spring-cloud-contract-spec-java/src/main/java/org/springframework/cloud/contract/spec/internal/RegexPatterns.java#L55C45-L55C45

The regex for double values does not consider possible values ("E-", e.g.: 1.0074598709275406E-4)
https://github.com/spring-cloud/spring-cloud-contract/blob/cd0fffa972cf3065c29ec1b29b13585c30a7345a/specs/spring-cloud-contract-spec-java/src/main/java/org/springframework/cloud/contract/spec/internal/RegexPatterns.java#L55C45-L55C45

which causes intermittent exception here

spring-cloud-contract/specs/spring-cloud-contract-spec-java/src/main/java/org/springframework/cloud/contract/spec/internal/PatternValueDslProperty.java

Line 38 in cd0fffa

throw new IllegalStateException("The generated value [" + generatedValue

with double values produced by the line this.random.nextInt(100) + this.random.nextDouble()

spring-cloud-contract/specs/spring-cloud-contract-spec-java/src/main/java/org/springframework/cloud/contract/spec/internal/PatternValueDslProperty.java

Line 88 in cd0fffa

    
           return createAndValidateProperty(RegexPatterns.DOUBLE, this.random.nextInt(100) + this.random.nextDouble());

spring-cloud-issues added the waiting-for-triage label

marcingrzejszczak added bug and removed waiting-for-triage labels

Contributor

marcingrzejszczak commented Dec 29, 2023

I guess we should go with more sophisticated regular expressions like this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment