Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultX509Source should have the ability to set up more options on WorkloadApiClient #79

Open
alwaysastudent opened this issue Aug 12, 2021 · 2 comments

Comments

@alwaysastudent
Copy link

Currently we can configure, spiffeSocketPath over io.spiffe.workloadapi.DefaultX509Source.X509SourceOptions.

But there are more configuration options available on io.spiffe.workloadapi.DefaultWorkloadApiClient.ClientOptions which we would like to customize while creating a new X509 source. Is it possible to make ClientOptions be configurable from X509SourceOptions as well?

Also would be great if retryExecutor can also be made customizable?

Sometimes we would like to run these as daemon threads instead.

@maxlambrecht
Copy link
Member

It makes sense to me.

@alwaysastudent, would you be willing to submit a PR ?

@alwaysastudent
Copy link
Author

alwaysastudent commented Aug 12, 2021

Sure, thank you. I can submit a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants