Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing check for 'typ' in token's header #158

Open
glaucimar opened this issue Jan 26, 2021 · 3 comments · May be fixed by #307
Open

missing check for 'typ' in token's header #158

glaucimar opened this issue Jan 26, 2021 · 3 comments · May be fixed by #307

Comments

@glaucimar
Copy link

JWTSVID specification states that field 'typ' in header is optional, however, if present, it must be set to either JWT or JOSE. This is not currently being checked in jwtsvid package (not in ParseInsecure nor in ParseAndValidate functions).
@evan2645
Copy link
Member

evan2645 commented Feb 4, 2021

Thank you for opening this @glaucimar! We should definitely be checking this... Any chance you'd be willing to send a patch?

@glaucimar
Copy link
Author

You are welcome, @evan2645 ... @langbeck already volunteered to send a patch. ;)

@langbeck
Copy link

langbeck commented Feb 5, 2021

I'll be looking into that next week =)

@langbeck langbeck mentioned this issue Feb 8, 2021
Closed
@nstott nstott linked a pull request Oct 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: check for invalid 'typ' headers nstott/go-spiffe
3 participants
@evan2645 @langbeck @glaucimar