Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: disable refreshing of Instagram embeds by config #208

Closed
arifje opened this issue May 20, 2022 · 2 comments
Closed

Feature request: disable refreshing of Instagram embeds by config #208

arifje opened this issue May 20, 2022 · 2 comments

Comments

@arifje
Copy link
Contributor

arifje commented May 20, 2022

If I am correct, the weekly refresh of Instagram data isn't required if you're using an embed code; this code never changes. Only the preview image expires on a weekly base. So why do a refresh every week in this case if you're not using this image?

We've disabled the refresh manually in the plugin a while ago. and all content seems to work fine after several months. So maybe it's a good idea to create a config variable, which skips or disables this refreshing part; enabled by default, but optionally disabled.

Thanks!

@ttempleton
Copy link
Contributor

The subject of refreshing embedded assets with expired images came up again recently with LinkedIn mentioned in #204, so it might be worth expanding auto-refreshing by adding a way for users to add rules for which embedded assets should be auto-refreshed (e.g. by provider name or URL), along with adding a setting to enable/disable.

@ttempleton
Copy link
Contributor

Just released Embedded Assets 3.0.2 with the enableAutoRefresh plugin setting (defaults to true), which controls whether Instagram embedded assets are auto-refreshed. I've opened #210 for the ability to add rules for auto-refreshing, and once that's done, the enableAutoRefresh setting will control whether that is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants