Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshes in displayValue have area and volume as zero. #3112

Open
5 tasks done
ks-cph opened this issue Dec 18, 2023 · 2 comments
Open
5 tasks done

Meshes in displayValue have area and volume as zero. #3112

ks-cph opened this issue Dec 18, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@ks-cph
Copy link
Contributor

ks-cph commented Dec 18, 2023

Prerequisites

What package are you referring to?

The problem occurs when converting objects from Revit and ArchiCAD. I expect the same for other connectors.

Describe the bug

The Meshes in displayValue have the properties area and volume. However, the Revit connector does not add the correct information and instead sets them to 0.

To Reproduce

Check the area or volume property of any element in the displayValue array.

Expected behavior

We would expect the correct area and volume of the meshes.

Screenshots

Bildschirmfoto 2023-12-18 um 11 45 53

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Failure Logs

Additional context

Proposed Solution (if any)

From Revit, it should be rather straightforward to add the information. When converting the geometry from Revit into speckle objects, we could add the volume and area for Revit.DB.Solid and the area for Revit.DB.Mesh. This information is already part of the corresponding Revit elements. Hence, it should not require a lot of computational power.

Optional: Affected Projects

@jsdbroughton
Copy link
Contributor

@ks-cph What is the correct interpretation of Area for the Mesh?

Let's say a CLT Floor Slab or a Drywall Wall - is this Plan Area, Face area?

@ks-cph
Copy link
Contributor Author

ks-cph commented Jan 18, 2024

Hey @jsdbroughton,

thanks for your response.
In my opinion, this property should address the surface of the Mesh without interpreting the domain knowledge such as using the plan area for a slab and the side area for a wall. This area property should aggregate all faces of the Mesh into one value.

Now we could argue that all information is stored in the vertices and faces arrays. But then again, why is there an Area property? And this is what I hoped to find out. I guess there is a reason why the area property was added, and I guess there is also a good reason to set it to zero. For me as a user, however, it would be very beneficial to get the numbers directly without computing each individual face area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants