Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Data button to also load region files #2188

Closed
Jdaviz-Triage-Bot opened this issue May 10, 2023 · 0 comments · Fixed by #2201
Closed

Import Data button to also load region files #2188

Jdaviz-Triage-Bot opened this issue May 10, 2023 · 0 comments · Fixed by #2201
Labels
feature Feature request imviz

Comments

@Jdaviz-Triage-Bot
Copy link

Jdaviz-Triage-Bot commented May 10, 2023

Reporter: pllim

With image already loaded in Imviz, user click the "Import Data" button and select a region file (*.reg), the parser would be smart enough to run the load_regions method behind the scenes.

This would allow region file loading on standalone app with no API access. Therefore, this also allows non-interactive drawing of annulus in Imviz because annulus shape is now supported as of glue-viz/glue-astronomy#90 .

It is already implemented in #2164 but the relevant code needs to be plucked out for a clean PR. Also for annulus support only, also need new glue-astronomy release upstream (>0.7) and then update the pin in pyproject.toml (as needed).

🐱


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request imviz
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants