Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specviz2d: plot spectrum in wavelength/frequency with non-linear axis #2150

Closed
3 tasks
kecnry opened this issue Apr 13, 2023 · 4 comments
Closed
3 tasks

specviz2d: plot spectrum in wavelength/frequency with non-linear axis #2150

kecnry opened this issue Apr 13, 2023 · 4 comments

Comments

@kecnry
Copy link
Member

kecnry commented Apr 13, 2023

#1514 forced the 1d spectrum to be plotted in pixel-space to maintain limit-syncing with the 2d spectrum until support for a non-linear x-axis on the 1d spectrum viewer could be supported.

Related:

Tasks

Preview Give feedback

🐱

@astrofrog
Copy link
Collaborator

Now that a new version of bqplot has been released with fixes for the custom axis labeling (thanks @mbreddels!) I've been able to wrap up a first prototype of glue-jupyter's profile viewer which can show the profile in pixel space while having the labeling be world coordinates, which was requested for Specviz2D. To try this out, you will need:

With these in place, you can then set x_att on the viewer state for the profile viewer to be a pixel component, and then toggle display of world vs pixel coordinates using the x_display_world boolean property on the viewer state. This should respect x_display_units. Let me know if this is looking promising, and I can try and wrap up the pull requests by adding tests etc and getting them into a released version.

@astrofrog
Copy link
Collaborator

The glue-jupyter PR has a demo notebook in case you want to test this out easily.

@astrofrog
Copy link
Collaborator

Just to check, where do we stand on this?

@kecnry
Copy link
Member Author

kecnry commented Jun 16, 2023

I think we can probably consider this closed by #2219 (abandoning the actual idea to plot with non-linear axis because of the consequences of needing to translate everything after the case)

@pllim pllim closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants