Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Remove Favorite" button only removes it visually #132

Open
k3yw opened this issue Jan 7, 2024 · 0 comments
Open

"Remove Favorite" button only removes it visually #132

k3yw opened this issue Jan 7, 2024 · 0 comments

Comments

@k3yw
Copy link

k3yw commented Jan 7, 2024

If you had server added to your favorites several times, removing them all from your favorites or keeping just one entry will still make the launcher query server multiple times

Here's how you replicate it:

  1. Add server multiple times to your favorites
  • For example: ss14://domain.com:1212, ss14://domain.com, ss14://ip:1212, ss14://subdomain.com, ss14://subdomain.com:1212
  1. Refresh the list
  2. Remove them all or keep just one
  3. Refresh the list again
  4. Watch your server's console report multiple queries at once instead of 0 or 1

image

@k3yw k3yw changed the title "Remove from favorite" button only removes it visually (?) "Remove Favorite" button only removes it visually (?) Jan 7, 2024
@k3yw k3yw changed the title "Remove Favorite" button only removes it visually (?) "Remove Favorite" button only removes it visually Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant