Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable policyIDs in next few sourcehub version bumps #3070

Open
shahzadlone opened this issue Sep 25, 2024 · 0 comments · May be fixed by #3171
Open

Unstable policyIDs in next few sourcehub version bumps #3070

shahzadlone opened this issue Sep 25, 2024 · 0 comments · May be fixed by #3171
Assignees
@shahzadlone
Labels
area/acp Related to the acp (access control) system area/testing Related to any test or testing suite bump Bumped version for something ci/build This is issue is about the build or CI system, and the administration of it. deprecate Indicates something is deprecated.

Comments

@shahzadlone
Copy link
Member

Unstable policyIDs in next few sourcehub version bumps so rework policyIDs in tests to be stored in state and not be explicitly required.

It's not as straight forward as DocIndex and CollectionIndex because policy id is to be embedded in the schema that gets loaded.

Like likely work on this in the cool down week.
@shahzadlone shahzadlone added area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it. deprecate Indicates something is deprecated. bump Bumped version for something area/acp Related to the acp (access control) system labels Sep 25, 2024
@shahzadlone shahzadlone self-assigned this Sep 25, 2024
@fredcarle fredcarle mentioned this issue Oct 7, 2024
Merged
4 tasks
@shahzadlone shahzadlone linked a pull request Oct 22, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
area/acp Related to the acp (access control) system area/testing Related to any test or testing suite bump Bumped version for something ci/build This is issue is about the build or CI system, and the administration of it. deprecate Indicates something is deprecated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(i): Refactor tests to avoid asserting policyIDs shahzadlone/defradb
1 participant
@shahzadlone