Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify usage of IdentifierAttribute and add IdentifierProperty for fields/properties #237

Open
varungandhi-src opened this issue Apr 22, 2024 · 0 comments
Open

Clarify usage of IdentifierAttribute and add IdentifierProperty for fields/properties #237

varungandhi-src opened this issue Apr 22, 2024 · 0 comments
Labels
graph/scip team/graph

Comments

@varungandhi-src
Copy link
Contributor

It looks like a bunch of queries in our highlighting logic in the Sourcegraph monorepo are misusing IdentifierAttribute for marking properties, which are syntactically very different from __attribute__ in C or similar. We should add IdentifierProperty first, and clarify the docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
graph/scip team/graph
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@varungandhi-src