Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Incorrect Artist.uri #1

Open
saihaj opened this issue May 10, 2022 · 2 comments
Open

Incorrect Artist.uri #1

saihaj opened this issue May 10, 2022 · 2 comments

Comments

@saihaj
Copy link
Member

saihaj commented May 10, 2022

@schmidsi
Copy link
Contributor

There was probably an update to the baseUri between this subgraph was running first and now. Still, it would be possible to simply override this function here:

https://github.com/soundxyz/subgraph/blob/main/src/Artist.ts#L211

Maybe we can skip artistContract.try_tokenURI(tokenId) completely and create the Artist.uri directly from the tokenId in that function.

@schmidsi
Copy link
Contributor

Would also increase indexing speed a bit since .try_tokenURI(tokenId)is an eth-call that takes 200-500ms to resolve.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants