Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very large timeout values cause immediate render failures. #78

Open
markstos opened this issue Jan 30, 2015 · 2 comments
Open

Very large timeout values cause immediate render failures. #78

markstos opened this issue Jan 30, 2015 · 2 comments

Comments

@markstos
Copy link
Contributor

I happened to put in a huge timeout value to render as a way to express that it should never timeout, since I was debugging:

   timeout: 100000000000000000

Instead of getting the expected unlimited timeout, I got immediate failure. We should validate the timeout value before passing it on. Other invalid values cause immediate render failure as well:

timeout: "BOOM"

I'm not currently sure what the maximum allowed value for timeout is.

@replete
Copy link

replete commented Jun 19, 2017

Well maybe your number is just too damn big for the data type? Try Number.MAX_SAFE_INTEGER (which is 9007199254740991)

@markstos
Copy link
Contributor Author

Validating inputs is a best practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants