Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reminder should preserve STATUSMSG prefix #10

Open
dgw opened this issue Dec 6, 2023 · 3 comments · May be fixed by #11
Open

Reminder should preserve STATUSMSG prefix #10

dgw opened this issue Dec 6, 2023 · 3 comments · May be fixed by #11
Assignees
@Exirel
Labels
bug Something isn't working

Comments

@dgw
Copy link
Member

dgw commented Dec 6, 2023

Saving the trigger.sender alone doesn't preserve the status prefix of the reminder command, as of sopel-irc/sopel#2370 (forthcoming 8.0). Simply put, if a reminder is set via PRIVMSG +#channel :.in 1h only voices know about this, the reminder in 1 hour is sent as PRIVMSG #channel :initiator: only voices know about this (I'm simplifying the protocol bits, obviously).

This is surprising, and probably not in a good way. It's the same reason we wanted sopel-irc/sopel#2441, to make it so that responses to commands (or triggers in general) aren't visible to more users than could see the command/trigger itself.
@dgw dgw added the bug Something isn't working label Dec 6, 2023
@dgw dgw mentioned this issue Apr 21, 2024
Merged
@half-duplex
Copy link
Member

Could this be hotfixed by just having the plugin prepend the status_prefix itself when setting a reminder?

@dgw
Copy link
Member Author

dgw commented Apr 22, 2024

Most likely.

@Exirel Exirel self-assigned this Apr 23, 2024
@Exirel
Copy link
Collaborator

Exirel commented Apr 23, 2024

Most likely yes, there is no need to manage more than that I think?

@Exirel Exirel linked a pull request Apr 27, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Exirel Exirel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backend: be ready for Sopel 8 sopel-irc/sopel-remind
3 participants
@dgw @half-duplex @Exirel