Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenRequest feature gate no longer relevant in 1.21 #37

Open
day0ops opened this issue May 20, 2021 · 2 comments
Open

TokenRequest feature gate no longer relevant in 1.21 #37

day0ops opened this issue May 20, 2021 · 2 comments

Comments

@day0ops
Copy link

day0ops commented May 20, 2021 •
edited
Loading

Looks like TokenRequest feature gate in 1.21 has been promoted as mentioned in changelog so no longer relevant.

This change impacts control planes created for new clusters. Leads to error

May 20 04:22:08 kind1-control-plane kubelet[290]: E0520 04:22:08.186018     290 server.go:216] "Failed to set feature gates from initia
l flags-based config" err="unrecognized feature gate: TokenRequest"

Either we should put a pre-req or fix the deploy.sh to take this into account.
@day0ops
Copy link
Author

day0ops commented May 20, 2021

cc @linsun ... happy to raise a PR for this

@linsun
Copy link
Contributor

linsun commented May 21, 2021

@djannot I think you have fixed this yesterday in the deploy.sh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@linsun @day0ops