From ed991ecc6871a975bd42398ed0081b43dd124fc0 Mon Sep 17 00:00:00 2001 From: Ethan Date: Mon, 28 Nov 2022 18:00:00 -0500 Subject: [PATCH] Move check for test directories (#23) --- changelog/v0.1.3/directory_check.yaml | 5 +++++ testutils/helper/install.go | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 changelog/v0.1.3/directory_check.yaml diff --git a/changelog/v0.1.3/directory_check.yaml b/changelog/v0.1.3/directory_check.yaml new file mode 100644 index 0000000..a23f5cd --- /dev/null +++ b/changelog/v0.1.3/directory_check.yaml @@ -0,0 +1,5 @@ +changelog: + - type: FIX + issueLink: https://github.com/solo-io/solo-projects/issues/4191 + resolvesIssue: false + description: Move check for _test and _build directories so that it only occurs when installing from locally built versions. \ No newline at end of file diff --git a/testutils/helper/install.go b/testutils/helper/install.go index 1b5e699..0343aa2 100644 --- a/testutils/helper/install.go +++ b/testutils/helper/install.go @@ -81,12 +81,12 @@ func NewSoloTestHelper(configFunc TestConfigFunc) (*SoloTestHelper, error) { if configFunc != nil { testConfig = configFunc(defaults) } - if err := validateConfig(testConfig); err != nil { - return nil, errors.Wrapf(err, "test config validation failed") - } // Get chart version if testConfig.ReleasedVersion == "" { + if err := validateConfig(testConfig); err != nil { + return nil, errors.Wrapf(err, "test config validation failed") + } version, err := getChartVersion(testConfig) if err != nil { return nil, errors.Wrapf(err, "getting Helm chart version")