Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnwrapAsAlb should be a transformer to match the pattern of other AWS transformations #205

Open
jbohanon opened this issue Feb 22, 2023 · 0 comments

Comments

@jbohanon
Copy link
Contributor

When wrapAsApiGateway and unwrapAsApiGateway were implemented, they were implemented as custom transformers which were defined in envoy-gloo-ee to protect them as enterprise features. After moving unwrapAsApiGateway into OSS, and looking ahead toward other potential request/response transformer implementations, it makes sense to extract the logic for unwrapAsAlb out into a custom transformer as well. This will be more uniform and will serve to simplify the internal API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant