Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size of ipv6 in documentation #98

Open
kot-begemot-uk opened this issue Feb 22, 2023 · 2 comments
Open

Size of ipv6 in documentation #98

kot-begemot-uk opened this issue Feb 22, 2023 · 2 comments

Comments

@kot-begemot-uk
Copy link

Version

N/A

Linux Version

N/A

Describe the bug

This passage in the documentation cannot be right. ipv6 as a u32?

https://github.com/solo-io/bumblebee/blob/main/docs/concepts.md

// A basic ipv4 address represented as a u32
typedef u32 ipv4_addr;
// A basic ipv6 address represented as a u32
typedef u32 ipv6_addr;
// A duration in NS stored as a u64
typedef u64 duration;

Steps to reproduce the bug

N/A

Expected Behavior

ipv4 should be u128

Additional Context

N/A

@krisztianfekete
Copy link
Contributor

Thanks for opening this issue! That's correct, unsigned __int128 would be fine for ipv6. Not just in the docs, but in the header file for the solo types as well. Would you be interested in contributing a fix for these?

@kot-begemot-uk
Copy link
Author

Sure. Probably a couple of days though. I was only reading the docs, not at the point of setting up the build environment and building it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants