New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] 피드백 #47

Open

crongro opened this issue Feb 6, 2023 · 1 comment

Labels

🙋‍♂️ Question

crongro commented Feb 6, 2023

전체 SPA기반 구조가 잘 잡혔네요.

유틸리티는 모두 다른 파일로 만들지 않고, 한 파일에 모아두어도 될 듯. 양도 적으니.

AuthPage.ts 의 inputs 객체는 상수처럼 고정된 것이라면 이곳에 있는것이 맞고, 변경가능성이 있다면 서버에서 가져오고요.

core/router 모듈 잘 만든것 같네요.

화이팅임다.

crongro added the 🙋‍♂️ Question label

Collaborator

SUMMERLOVE7 commented Feb 6, 2023

피드백 감사합니당😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment