Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changepoints to instrumentation data #57

Open
snim2 opened this issue May 3, 2018 · 2 comments
Open

Add changepoints to instrumentation data #57

snim2 opened this issue May 3, 2018 · 2 comments

Comments

@snim2
Copy link
Contributor

snim2 commented May 3, 2018

The intention here is to make it easier for the user to see correlations between changes in timing data and changes in instrumentation data.

@snim2
Copy link
Contributor Author

snim2 commented Aug 21, 2018

Note: This issue needs some detailed documentation.

@snim2 snim2 self-assigned this Aug 21, 2018
@snim2
Copy link
Contributor Author

snim2 commented Aug 21, 2018

Currently we use the changepoint to add changepoint data to our Krun JSON. We spent a long time running our example data through the changepoint library with different parameters, until we found something that seemed to work well for most of our VM / benchmark combinations.

In order to produce useful changepoints for instrumentation data, we would need to look again at how to parameterise the R library functions that we're using.

However, since we first wrote the changepoint code, @rkillick has developed EnvCpt which is a new version of the R changepoint code, which does not need to be parameterised. This would be a more robust option for the instrumentation data, but it would need to be well tested. It would also be worth moving the core changepoint code here to use EnvCpt, but again that would need careful testing over a large dataset.

@snim2 snim2 removed their assignment Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant