Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated opentelemetry dependency creating conflicts #2192

Open
lewis-anderson53 opened this issue Dec 17, 2024 · 7 comments · May be fixed by #2199
Open

Outdated opentelemetry dependency creating conflicts #2192

lewis-anderson53 opened this issue Dec 17, 2024 · 7 comments · May be fixed by #2199

Comments

@lewis-anderson53
Copy link

The currently supported versions of opentelemetry are up to 1.22 which are now a year old. This was last changed in march this year via #2043.

The reason I've stumbled across this is due to Airflow no longer supporting opentelemetry <1.22 explicitly in their most recent release.

The package version limit committed to in soda-core in March '24 appears to maintain support for Python 3.7, which makes it more of a tricky discussion I'm sure, however not moving with later versions of other python packages (opentelemetry is just the current problem) will cause many conflicts with other packages in the future I'm sure.

It would be nice to move on from 3.7 which will mean many other packages (e.g markupsafe #2103) can also be bumped.

@tools-soda
Copy link

CLOUD-9045

@nathadfield
Copy link
Contributor

FYI:

48.93 ERROR: Cannot install apache-airflow==2.10.4+astro.1 and soda-core-bigquery because these package versions have conflicting dependencies.
48.93 
48.93 The conflict is caused by:
48.93     apache-airflow 2.10.4+astro.1 depends on opentelemetry-api>=1.24.0
48.93     soda-core 3.3.0 depends on opentelemetry-api~=1.16.0
48.93 

@PatziRi
Copy link

PatziRi commented Dec 20, 2024

I've also found that MarkupSafe has the same issue, as soda-core 3.4.2 depends on MarkupSafe 2.12 while airflow requires version 2.1.5

@ghjklw
Copy link

ghjklw commented Jan 2, 2025

To add to the discussion, Python 3.7 reached end-of-life in June 2023, a year and a half ago!
There should be no reason to maintain compatibility with a no longer supported version of Python. Those who decide to stick with Python 3.7 should also accept to stick with an older version of Soda, instead of creating dependency conflicts for those who maintain their dependencies updated.

By the way, Python 3.8 is also end-of-life now.

@nathadfield
Copy link
Contributor

Package conflicts when attempting to use soda-core 3.4.3

15.98 ERROR: Cannot install apache-airflow==2.10.4+astro.1 and soda-core-bigquery because these package versions have conflicting dependencies.
15.98 
15.98 The conflict is caused by:
15.98     soda-core 3.4.3 depends on opentelemetry-api<1.23.0 and >=1.16.0
15.98     apache-airflow 2.10.4+astro.1 depends on opentelemetry-api>=1.24.0
15.98 

@swathigottumukkala
Copy link

we are blocked on integrating soda into our existing service due to this issue, appreciate if the work can be
prioritized

@swathigottumukkala
Copy link

may I ask if there are plans to update telemetry dependencies in the near future? If not, I may have time to look into this following the instructions in CONTRIBUTING.MD.

ghjklw added a commit to ghjklw/soda-core that referenced this issue Jan 22, 2025
Release soda-core version contraint for
opentelemetry as there is no reason to support
Python 3.7 and this is creating dependency
conflicts with many other libraries.
@ghjklw ghjklw linked a pull request Jan 22, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants