Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put hard upper limits on page size #7

Open
dimitarvp opened this issue Jul 18, 2019 · 1 comment
Open

Put hard upper limits on page size #7

dimitarvp opened this issue Jul 18, 2019 · 1 comment

Comments

@dimitarvp
Copy link
Contributor

As @elvanja suggested, we should have some sensible hard upper bound on page_size.

I'd propose 100_000 but even that might be too much. Most programming languages don't cope well with such huge batches. Elixir seems to do fine with 500 to 10_000.

@elvanja
Copy link

elvanja commented Jul 18, 2019

Whatever number we come up with, it should be configurable / overridable. Probably not that many cases where page size would be that high, but still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants