Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1874061: Support injecting custom socketFactory #2018

Open
mayankvadariya opened this issue Jan 2, 2025 · 3 comments
Open

SNOW-1874061: Support injecting custom socketFactory #2018

mayankvadariya opened this issue Jan 2, 2025 · 3 comments
Assignees
Labels
enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team

Comments

@mayankvadariya
Copy link

What is the current behavior?

Snowflake JDBC doesn't allow injecting custom socketFactory

What is the desired behavior?

Snowflake JDBC to support injecting custom socketFactory

How would this improve snowflake-jdbc?

It helps client pass in additional socket options while making a connection

References, Other Background

Majority of the data sources supporting JDBC connectivity has builtin support for injecting custom socketFactory

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage_done Initial triage done, will be further handled by the driver team label Jan 3, 2025
@sfc-gh-dszmolka
Copy link
Contributor

hi and thank you for raising this Issue with us. I"m wondering why would this capability be necessary, can you please expand on the use-case ? Asking because currently the driver supports a number of [user-exposed timeouts[(https://docs.snowflake.com/en/developer-guide/jdbc/jdbc-parameters#timeout-parameters) so I'm curious what is missing.

@sfc-gh-dszmolka sfc-gh-dszmolka added question Issue is a usage/other question rather than a bug status-triage Issue is under initial triage status-information_needed Additional information is required from the reporter and removed feature status-triage_done Initial triage done, will be further handled by the driver team labels Jan 3, 2025
@mayankvadariya
Copy link
Author

hi @sfc-gh-dszmolka thanks for checking this issue. Most of the popular JDBC drivers such as mysql, postgresql already supports custom SocketFactory implementations, allowing for enhanced security and custom network configurations. Our use case is pretty much along the same lines i.e to enforce stronger security measures, such as custom SSL/TLS configurations. Our application also needs add detailed logging of socket connection along with customizing some of the other network configuration.

@mayankvadariya mayankvadariya changed the title Support injecting customer socketFactory Support injecting custom socketFactory Jan 3, 2025
@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title Support injecting custom socketFactory SNOW-1874061: Support injecting custom socketFactory Jan 7, 2025
@sfc-gh-dszmolka
Copy link
Contributor

thank you for providing us with the use-case! the team will consider this request for future planning.

@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team and removed question Issue is a usage/other question rather than a bug status-triage Issue is under initial triage status-information_needed Additional information is required from the reporter labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Development

No branches or pull requests

3 participants