Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1528939 - Updated 3rd party maven proxy reference from nexus to artifactory #1905

Conversation

sfc-gh-kashah
Copy link
Contributor

@sfc-gh-kashah sfc-gh-kashah commented Sep 27, 2024

Overview

SNOW-1528939 - Updated the 3rd party maven proxy reference from nexus to artifactory

As part of the security initiative, the artifactory team will be deprecating the 3rd party artifact proxy in Nexus. All the 3rd party artifacts will be called from artifactory.

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

@sfc-gh-kashah sfc-gh-kashah requested a review from a team as a code owner September 27, 2024 19:28
Copy link

github-actions bot commented Sep 27, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-jfan
Copy link
Collaborator

Hey, @sfc-gh-igarish would you mind taking a look at this PR raised by ES team? thanks!
cc: @sfc-gh-kashah

@sfc-gh-pmotacki
Copy link
Contributor

sfc-gh-pmotacki commented Sep 30, 2024

Hi @sfc-gh-jfan. This change looks go to me. Please add the CLA clause.

@sfc-gh-kashah
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-kashah sfc-gh-kashah changed the title SNOW-1006018 - Updated 3rd party maven proxy reference from nexus to artifactory SNOW-1528939 - Updated 3rd party maven proxy reference from nexus to artifactory Sep 30, 2024
@sfc-gh-kashah sfc-gh-kashah force-pushed the kashah-SNOW-1006018-update-maven-reference-nexus-artifactory branch from 85343d4 to 5e49c4f Compare October 1, 2024 01:14
@sfc-gh-kashah sfc-gh-kashah merged commit 5e4585b into master Oct 1, 2024
142 checks passed
@sfc-gh-kashah sfc-gh-kashah deleted the kashah-SNOW-1006018-update-maven-reference-nexus-artifactory branch October 1, 2024 17:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants