Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1045676: Update getSQLKeywords to match actual reserved keywords in Snowflake #1630

Closed
dahoorma opened this issue Feb 7, 2024 · 3 comments
Closed

SNOW-1045676: Update getSQLKeywords to match actual reserved keywords in Snowflake #1630

dahoorma opened this issue Feb 7, 2024 · 3 comments
Assignees
@sfc-gh-snow-drivers-warsaw-dl
Labels
bug status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team

Comments

@dahoorma
Copy link

dahoorma commented Feb 7, 2024

What is the current behavior?

The getSQLKeywords method returns a list of keywords that does not match the Snowflake documentation and restricts words that are actually allowed in Snowflake, such as NAME.

It also does not include keywords, such as ILIKE, that are restricted by Snowflake.

What is the desired behavior?

The method should return the accurate list of reserved keywords.

How would this improve snowflake-jdbc?

Applications that use this metadata to restrict keywords would have the accurate information available.

References, Other Background

Snowflake Reserved and Limited Keywords
@github-actions github-actions bot changed the title Update getSQLKeywords to match actual reserved keywords in Snowflake SNOW-1045676: Update getSQLKeywords to match actual reserved keywords in Snowflake Feb 7, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added bug status-triage Issue is under initial triage and removed feature labels Mar 5, 2024
@sfc-gh-sghosh sfc-gh-sghosh added status-triage_done Initial triage done, will be further handled by the driver team and removed status-triage Issue is under initial triage labels Mar 6, 2024
@sfc-gh-sghosh
Copy link
Contributor

Hello @dahoorma ,

Thank you raising this issue, we confirmed the gap, we will work on eliminating it.

Regards,
Sujan

@sfc-gh-sghosh sfc-gh-sghosh removed their assignment Mar 6, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-pr_pending_merge A PR is made and is under review label Mar 15, 2024
@sfc-gh-sghosh
Copy link
Contributor

Hello @dahoorma ,

PR is currently under review #1670

Regards,
Sujan

@sfc-gh-dszmolka
Copy link
Contributor

PR is merged and just checked, apparently part of the 2024 April release (v3.16.0) which was just released yesterday.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-pr_pending_merge A PR is made and is under review labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-snow-drivers-warsaw-dl sfc-gh-snow-drivers-warsaw-dl

Labels
bug status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dahoorma @sfc-gh-dszmolka @sfc-gh-sghosh @sfc-gh-snow-drivers-warsaw-dl