Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1634712 Support for toml file connection configuration #1204

Merged
merged 53 commits into from
Oct 17, 2024

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Aug 30, 2024

Description

SNOW-1634712 Please explain the changes you made here.

  • support establishing connection to Snowflake by reading the connections.toml configuration file.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 27 lines in your changes missing coverage. Please review.

Project coverage is 82.79%. Comparing base (8224d28) to head (e6798f0).

Files with missing lines Patch % Lines
connection_configuration.go 90.44% 26 Missing ⚠️
driver.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
+ Coverage   82.61%   82.79%   +0.18%     
==========================================
  Files          54       55       +1     
  Lines       12916    13194     +278     
==========================================
+ Hits        10670    10924     +254     
- Misses       2246     2270      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review September 5, 2024 19:54
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner September 5, 2024 19:54
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as draft September 5, 2024 19:54
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title SNOW-1634712 SNOW-1634712 Support for toml file connection configuration Sep 6, 2024
errors.go Outdated Show resolved Hide resolved
connection_configuration_test.go Outdated Show resolved Hide resolved
connection_configuration.go Outdated Show resolved Hide resolved
connection_configuration.go Outdated Show resolved Hide resolved
connection_configuration.go Outdated Show resolved Hide resolved
connection_configuration.go Outdated Show resolved Hide resolved
connection_configuration.go Outdated Show resolved Hide resolved
connection_configuration.go Outdated Show resolved Hide resolved
connection_configuration.go Outdated Show resolved Hide resolved
connection_configuration.go Outdated Show resolved Hide resolved
connection_configuration_test.go Show resolved Hide resolved
@sfc-gh-dheyman-1
Copy link
Collaborator

sfc-gh-dheyman-1 commented Oct 2, 2024

Hi @sfc-gh-ext-simba-jy , unfortunately one of the added tests fails on MAC and UBUNTU machines:
=== RUN TestTokenFilePermission assert_test.go:97: expected to be not nil but was not. The error occurred because you cannot change the file permission. Thrown from /Users/runner/work/gosnowflake/gosnowflake/connection_configuration_test.go:23 +0x168 testing.tRunner(0xc000542000, 0x103690ee8) --- FAIL: TestTokenFilePermission (0.00s)

cmd/tomlfileconnection/Makefile Show resolved Hide resolved
cmd/tomlfileconnection/tomlfileconnection.go Outdated Show resolved Hide resolved
cmd/tomlfileconnection/tomlfileconnection.go Outdated Show resolved Hide resolved
connection_configuration.go Outdated Show resolved Hide resolved
connection_configuration.go Outdated Show resolved Hide resolved
connection_configuration.go Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit 5eda091 into master Oct 17, 2024
37 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the SNOW-1634712 branch October 17, 2024 02:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants