-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimistic timelocks #230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pscott
force-pushed
the
feat_optimistic_timelock
branch
from
June 29, 2023 14:14
e1d55c5
to
caad1d9
Compare
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
==========================================
+ Coverage 79.74% 80.00% +0.25%
==========================================
Files 28 30 +2
Lines 464 560 +96
Branches 112 127 +15
==========================================
+ Hits 370 448 +78
- Misses 78 95 +17
- Partials 16 17 +1
|
Orland0x
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uTACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits were made such that one can easily look at how the
Optimistic
versions were implemented by looking at those two commits:CompTimelock: 1a849db and e1e5192
Timelock: e2ff745
The commits
tmp:
are just commits that add a copy of the already existing code (to make the diff easy to read).Closes #229