Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimistic timelocks #230

Merged
merged 8 commits into from
Jun 30, 2023
Merged

feat: optimistic timelocks #230

merged 8 commits into from
Jun 30, 2023

Conversation

pscott
Copy link
Collaborator

@pscott pscott commented Jun 29, 2023

The commits were made such that one can easily look at how the Optimistic versions were implemented by looking at those two commits:

CompTimelock: 1a849db and e1e5192

Timelock: e2ff745

The commits tmp: are just commits that add a copy of the already existing code (to make the diff easy to read).

Closes #229

@pscott pscott force-pushed the feat_optimistic_timelock branch from e1d55c5 to caad1d9 Compare June 29, 2023 14:14
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #230 (c962056) into main (c3b5e3d) will increase coverage by 0.25%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   79.74%   80.00%   +0.25%     
==========================================
  Files          28       30       +2     
  Lines         464      560      +96     
  Branches      112      127      +15     
==========================================
+ Hits          370      448      +78     
- Misses         78       95      +17     
- Partials       16       17       +1     
Impacted Files Coverage Δ
...elocks/CompTimelockCompatibleExecutionStrategy.sol 82.35% <ø> (ø)
...strategies/timelocks/TimelockExecutionStrategy.sol 80.00% <ø> (ø)
.../timelocks/OptimisticTimelockExecutionStrategy.sol 80.00% <80.00%> (ø)
...imisticCompTimelockCompatibleExecutionStrategy.sol 82.35% <82.35%> (ø)

Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK

@pscott pscott marked this pull request as ready for review June 30, 2023 12:30
@pscott pscott merged commit 7437cfb into main Jun 30, 2023
@Orland0x Orland0x deleted the feat_optimistic_timelock branch October 11, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimistic Timelock
2 participants