Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Comp Timelock Doesn't Support Duplicate MetaTransaction Queueing #227

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

pscott
Copy link
Collaborator

@pscott pscott commented Jun 27, 2023

Closes #221

@pscott pscott requested a review from Orland0x June 27, 2023 12:14
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #227 (2cf8e8b) into main (b063080) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files          28       28           
  Lines         465      465           
  Branches      111      111           
=======================================
  Hits          375      375           
  Misses         74       74           
  Partials       16       16           
Impacted Files Coverage Δ
...tegies/CompTimelockCompatibleExecutionStrategy.sol 82.35% <100.00%> (ø)

@Orland0x Orland0x changed the title refactor: copy CompTimelock's behaviour in CompTimelockStrategy audit: Comp Timelock Doesn't Support Duplicate MetaTransaction Queueing Jun 27, 2023
Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK

@Orland0x Orland0x merged commit ff99184 into main Jun 27, 2023
@Orland0x Orland0x deleted the fix_silent_merge_on_duplicate_tx_timelock branch October 11, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit: Comp Timelock Doesn't Support Duplicate MetaTransaction Queueing
2 participants