Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: Comp Timelock Doesn't Support Duplicate MetaTransaction Queueing #221

Closed
pscott opened this issue Jun 26, 2023 · 0 comments · Fixed by #227
Closed

audit: Comp Timelock Doesn't Support Duplicate MetaTransaction Queueing #221

pscott opened this issue Jun 26, 2023 · 0 comments · Fixed by #227
Assignees
@pscott

Comments

@pscott
Copy link
Collaborator

pscott commented Jun 26, 2023

Our previous fix wasn't enough. We should mimic Comp Timelock's behaviour and store the transaction hashes in a mapping.
@Orland0x Orland0x changed the title Prevent Comp Timelock Duplicates audit: Comp Timelock Doesn't Support Duplicate MetaTransaction Queueing Jun 26, 2023
@pscott pscott mentioned this issue Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pscott pscott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

audit: Comp Timelock Doesn't Support Duplicate MetaTransaction Queueing snapshot-labs/sx-evm
1 participant
@pscott