Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: Optimize ActiveProposalLimiter storage reads #220

Closed
pscott opened this issue Jun 26, 2023 · 0 comments · Fixed by #226
Closed

audit: Optimize ActiveProposalLimiter storage reads #220

pscott opened this issue Jun 26, 2023 · 0 comments · Fixed by #226
Assignees
@Orland0x

Comments

@pscott
Copy link
Collaborator

pscott commented Jun 26, 2023

It accesses the fields of packedData repeatedly. While it's possible that the Solidity optimizer could optimize away some of the reads, in general it's not super reliable so best to optimize the storage accesses by hand if the performance matters.
@Orland0x Orland0x self-assigned this Jun 27, 2023
@Orland0x Orland0x changed the title Optimize ActiveProposalLimiter audit: Optimize ActiveProposalLimiter Jun 27, 2023
@Orland0x Orland0x changed the title audit: Optimize ActiveProposalLimiter audit: Optimize ActiveProposalLimiter Storage reads Jun 27, 2023
@Orland0x Orland0x changed the title audit: Optimize ActiveProposalLimiter Storage reads audit: Optimize ActiveProposalLimiter storage reads Jun 27, 2023
@Orland0x Orland0x mentioned this issue Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Orland0x Orland0x

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

audit: Optimize ActiveProposalLimiter storage reads snapshot-labs/sx-evm
2 participants
@pscott @Orland0x